Update GPU CI coverage #2236
Merged
Update GPU CI coverage #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
force-pushed
the
bc/buildkite-cov
branch
from
8ce1c4a
to
6a66843
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2236 +/- ##
==========================================
+ Coverage 76.30% 83.25% +6.94%
==========================================
Files 31 31
Lines 1819 1821 +2
==========================================
+ Hits 1388 1516 +128
+ Misses 431 305 -126 ☔ View full report in Codecov by Sentry. |
CarloLucibello
approved these changes
Sep 30, 2023
|
The coverage is increased but the error persists. I've asked on Slack to see if anyone knows what the issue is. |
|
We no longer have that Codecov submission error. Either I fixed it and forgot, or it fixed itself. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this fixes the "Cannot submit coverage without Codecov key" errors we've been getting recently as well.
PR Checklist
Tests are addedEntry in NEWS.mdDocumentation, if applicable