Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors for conv layers #2404

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Improve errors for conv layers #2404

merged 3 commits into from
Mar 21, 2024

Conversation

mcabbott
Copy link
Member

Fixes #2398

ToucheSir
ToucheSir approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have new CI failures on master, but none of them look related

@mcabbott mcabbott merged commit c4a0ee4 into FluxML:master Mar 21, 2024
3 of 8 checks passed
@mcabbott mcabbott deleted the friendly_errors branch March 21, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToucheSir ToucheSir ToucheSir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dimensions check for Conv is incomplete, leading to confusing error
2 participants
@mcabbott @ToucheSir