-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and refactoring #27
Conversation
@tejank10 Committing a second batch of fixes. Here is a summary of the notable changes...
|
@tejank10 added the requested changes. Please try to overlook the commit history mess. I ended up pushing the wrong commit to the wrong branch and that led to all kinds of trouble. Git wasn't being very nice. |
Nice work, @kraftpunk97 ! |
This PR contains fixes for the problems I encountered while preparing the demo for my JSoC report.
It fixes the following issues...
floor
was applied to thelow
fields of theBox
space, instead ofceil
. This fixes an issue where we may occasionally get an out-of-bound value for something likeBox(1.1, 3.4, Int32)
.The spaces are seldom used directly by the user. Exporting them to main API interface, which should only be for the functions that are used on a constant basis, is not the right choice. Therefore, those exports have been removed, and the environments can call them by the
using .Space
statementRemoved the export of
contains
fromSpace
module, asBase.in
has already been overloaded. to callcontains
Fixed an issue where calling the
render!()
function in:human_pane
or:rgb
mode would not display immediately in a script.Switched the order the
train
andrender_mode
arguments in the definition of themake
function. User will supply the value of therender_mode
argument in more cases than fortrain
, so train will be using its default value more often, and needs to be on the right side.