Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to JuliaLang/julia#46961 #101

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

aviatesk
Copy link
Contributor

@aviatesk aviatesk commented Oct 8, 2022

src/ir/wrap.jl Outdated
@@ -58,7 +58,11 @@ function IRCode(ir::IR)
sps = VERSION > v"1.2-" ? [] : Core.svec()

@static if VERSION > v"1.6-"
stmtinfo = Any[nothing for _ in 1:length(length(stmts))]
@static if isdefined(Core.Compiler, :CallInfo)
stmtinfo = Core.Compiler.CallInfo[Core.Compiler.NoCallInfo() for _ in 1:length(length(stmts))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Length of length?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length(::Number) always returns 1, so I guess this stmtinfo actually has been invalid. I will fix it up and see if the CI runs successfully.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, CI is successful. This should be ready.

@MikeInnes
Copy link
Member

Thanks @aviatesk!

@MikeInnes MikeInnes merged commit b3a1a0f into FluxML:master Oct 10, 2022
@aviatesk aviatesk deleted the avi/46961 branch October 11, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants