Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documenter docs #99

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Add documenter docs #99

merged 4 commits into from
Oct 31, 2018

Conversation

Roger-luo
Copy link
Contributor

#83

@Roger-luo
Copy link
Contributor Author

Used new documenter according: https://discourse.julialang.org/t/psa-use-a-project-for-building-your-docs/14974

MikeInnes
MikeInnes reviewed Oct 8, 2018
View reviewed changes
.gitignore
_*.dat
*.swp
__pycache__/
Manifest.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to include these, actually. In future we'll be using them for CI anyway.

MikeInnes
MikeInnes reviewed Oct 8, 2018
View reviewed changes
.travis.yml

env:
global:
- DOCUMENTER_DEBUG=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it right to leave this in when merging to master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on what you prefer. The configuration on discourse has the debug option on.

@MikeInnes
Copy link
Member

Is this still WIP?

@Roger-luo
Copy link
Contributor Author

Roger-luo commented Oct 30, 2018 •
edited
Loading

Oops, no. I think this can be merged now. We can polish the doc in other PRs.

@Roger-luo Roger-luo changed the title WIP: add documenter docs Add documenter docs Oct 30, 2018
@MikeInnes
Copy link
Member

Alright, thanks for setting this up!

@MikeInnes MikeInnes merged commit c8a0bf1 into FluxML:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeInnes MikeInnes MikeInnes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roger-luo @MikeInnes