Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cifar10 untar problem #12

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Fix Cifar10 untar problem #12

merged 2 commits into from
Jun 28, 2018

Conversation

avik-pal
Copy link
Member

Fixes #11

@codecov-io
Copy link

codecov-io commented Jun 26, 2018

Codecov Report

Merging #12 into master will increase coverage by 4.88%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   36.81%   41.69%   +4.88%     
==========================================
  Files          12       12              
  Lines         747      753       +6     
==========================================
+ Hits          275      314      +39     
+ Misses        472      439      -33
Impacted Files Coverage Δ
src/Metalhead.jl 0% <ø> (ø) ⬆️
src/datasets/autodetect.jl 73.52% <100%> (+49.28%) ⬆️
src/datasets/utils.jl 75% <0%> (+75%) ⬆️
src/datasets/cifar10.jl 80% <0%> (+80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0357f9...56bcbde. Read the comment docs.

@MikeInnes
Copy link
Member

Cool, thanks. Can you add a test for this?

@avik-pal
Copy link
Member Author

avik-pal commented Jun 26, 2018

1 small problem still. I think the line run(`tar -xzvf $local_path -C $dir_path`) will fail on Windows or any non-Linux based OS. Any suggestion as to how to handle this

@Keno
Copy link
Contributor

Keno commented Jun 28, 2018

1 small problem still. I think the line run(tar -xzvf $local_path -C $dir_path) will fail on Windows or any non-Linux based OS. Any suggestion as to how to handle this

BinaryProvider can do this, but I'm gonna go with let's merge this to fix the immediate problem, and we can address Windows compatibility later.

@Keno Keno merged commit b3c09e5 into FluxML:master Jun 28, 2018
@avik-pal avik-pal deleted the patch_1 branch June 28, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants