Removed extra mobilenetv1 fc layer, fcsize param #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theabhirath
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Thanks for the PR, seems good to me! Maybe @darsnack can comment on keeping the extra FC layer optionally?
darsnack
requested changes
Jul 28, 2022
There was a problem hiding this comment.
No, your proposed changes look great! I don't think we need to maintain the ability to have an intermediate layer.
Can you update the version in the Project.toml to 0.8.0-DEV so that we don't forget that there is now a breaking change for release? (You can commit and push more changes to your fork and this PR will auto-update).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#186
My first PR! Thanks @theabhirath for a good first issue. I found that the best way to fix was to also remove the
fcsizeparameter. It's not used by the non-configurable function, so I'm assuming it's not used much.It's also an option to set
fcsize = nothingand add extra layer iffcsize !== nothing.