-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a uniform API at the highest level for models #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theabhirath
force-pushed
the
refine
branch
2 times, most recently
from
August 1, 2022 15:14
00355aa
to
57a3ce7
Compare
Also a. more type annotations b. Expose only configurations vital to the model API in terms of pretraining at the highest level
Also a. more type annotations b. Expose only configurations vital to the model API in terms of pretraining at the highest level
Pending CI, this should be good to go! |
theabhirath
force-pushed
the
refine
branch
3 times, most recently
from
August 3, 2022 05:47
bb0bd62
to
5040439
Compare
darsnack
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of stuff:
inchannels
andnclasses
as uniform options for all models, helping along Addinchannels
,imsize
,nclasses
as kwargs for all constructors #176 - onlyimsize
is left now.invertedresidual
as prep for an EfficientNetv2 PR that will be landing shortly.create_classifier
in most cases where it can be for brevity