-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for MLUtils to 0.3, (keep existing compat) #204
CompatHelper: bump compat for MLUtils to 0.3, (keep existing compat) #204
Conversation
33d4c18
to
5cea72d
Compare
Seems like this is still valid? Flux bumped recently (but hasn't tagged yet) and Metalhead should too. |
yeah I wanted to retrigger CI but got distracted. Is the buildkite failure due to the breaching change in |
Test failures look all to be expected, so I think we're good to merge.
If https://github.com/BioTurboNick/AbbreviatedStackTraces.jl had an option to only collapse types but keep all frames, we could consider using that. @BioTurboNick could I bother you with this question? |
is there something holding from release? |
It's very breaking with possible loose ends post-GSoC. I need to look through carefully before releasing which I can do this weekend. |
PS - the docs are still very untidy. I was hoping we could switch to Pollen release before the v0.8 breaking release, but that may not happen. In case it's needed I can work on the docs a little bit to just make it release worthy (I am a little cramped ATM so I don't have the time to write the dev docs, but I will continue working on that when I get time). |
The change I made to collapse types is very rudimentary; I sort of consider that to be out of scope for my package, as I'm not confident it's a proper solution. But if you want to adopt it for your own purposes, this function I overrode in Base is what you need: https://github.com/BioTurboNick/AbbreviatedStackTraces.jl/blob/d7acfbe70bec422ce165da7d277e458aff61e119/src/AbbreviatedStackTraces.jl#L515 Just change what you're checking to set |
This pull request changes the compat entry for the
MLUtils
package from0.2.10
to0.2.10, 0.3
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.