Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the torchvision porting script #229

Merged
merged 4 commits into from
Apr 25, 2023
Merged

fix the torchvision porting script #229

merged 4 commits into from
Apr 25, 2023

Conversation

CarloLucibello
Copy link
Member

The models left uncommented in the model_list in the port_torchvision.jl script are successfully ported from torchvision
(on julia 1.9 rc2). Is there any need to reupload them on HuggingFace?

For SqueezeNet and DenseNet the script errors due to size mismatches. Maybe wrong ordering again?

close #228

@CarloLucibello
Copy link
Member Author

I guess #206 is a good reason for uploading on HF. Or we want to fix the issue mapping the old weights to the new implementations?

@darsnack
Copy link
Member

We can upload new weights, but I don't think running the script is the issue. All these weights already exist on HF, and they can be accessed on master. The issue is that BSON won't load models saved with Julia 1.7+ because TaskLocalRNG is not defined.

So I would say re-running this script with Julia 1.6, then uploading those weights will fix all the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mismatch with torchvision resnets
2 participants