Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models imported using ONNX added #6

Merged
merged 7 commits into from
Jun 1, 2018
Merged

Conversation

ayush1999
Copy link
Contributor

I've added three models (in this PR):

  1. Squeezenet
  2. DenseNet121
  3. ResNet50

All of them are working fine. Binaries could be added after this PR is merged. (along with the new release maybe)

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #6 into master will increase coverage by 25.04%.
The diff coverage is 47.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage   11.76%   36.81%   +25.04%     
===========================================
  Files           8       12        +4     
  Lines         221      747      +526     
===========================================
+ Hits           26      275      +249     
- Misses        195      472      +277
Impacted Files Coverage Δ
src/Metalhead.jl 0% <ø> (ø) ⬆️
src/googlenet.jl 0% <0%> (ø)
src/utils.jl 24.24% <100%> (+7.57%) ⬆️
src/resnet.jl 47.44% <47.44%> (ø)
src/densenet.jl 51.56% <51.56%> (ø)
src/squeezenet.jl 98% <98%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c8ea5...7ca20a5. Read the comment docs.

@ayush1999
Copy link
Contributor Author

@MikeInnes Should I add the binaries now, or after merging this? (Because the Travis CI would fail without adding them)

@MikeInnes
Copy link
Member

Go ahead and add the binaries -- let me know if you need access to do so.

For some of these it would be nice to write these out in a more compact way, e.g. that generates all the layers. This is fine for now though.

@ayush1999
Copy link
Contributor Author

@MikeInnes I might need push access to add the binaries. Also, I was thinking of releasing a new version along with the binaries, if it's not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants