Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes stops working (hotkeys) #184

Open
Marwe opened this issue Mar 8, 2024 · 10 comments
Open

Sometimes stops working (hotkeys) #184

Marwe opened this issue Mar 8, 2024 · 10 comments

Comments

@Marwe
Copy link

Marwe commented Mar 8, 2024

Sometimes the keyboard shortcuts to move/resize Windows stop working. I found no clear pattern yet, this might be related to hibernate states and/or switching screen setup.

If I switch the extension off, I get at least the standard gnome functionality back working.
Restarting gnome.-shell often helps to restore the full functionality.
Is there a possibility to reinit the plugin only without reinit of the gnome-shell?

May be unrelated, though I have no idea what changed the settings (may I accidentially while looking at it)
I found the settings were weird with one column only, explaining the following behaviour: super-left and -right keys maximize the window (super-top and -down work).
@GrylledCheez
Copy link
Collaborator

What version of gnome?

Please provide debug logs of you turning the extension on and then trying to replicate the weird single column behavior.

@Marwe
Copy link
Author

Marwe commented Mar 11, 2024

This might be related, while it was not working I got the first four lines of messages.
Window switching and moving to other virtual desktop or resizing failed.
If I recall correctly, ctrl-tab helped to focus correctly and then wintile also worked again (from [WinTile], --- on).
I woke up the machine from suspend before, monitor setup did not change (only native laptop display was used).
Version of gnome (on Ubuntu 22.04 here)
Version: 1:42+3

uniq -c /tmp/wintile.log 
     2 Mär 11 21:52:44 hostname gnome-shell[3734]: JS ERROR: TypeError: scrollView.vscroll is null
     1 Mär 11 21:52:44 hostname gnome-shell[3734]: JS ERROR: Error: Actor not in scroll view
    50 Mär 11 21:53:25 hostname gnome-shell[3734]: JS ERROR: TypeError: scrollView.vscroll is null
     1 Mär 11 21:53:25 hostname gnome-shell[3734]: JS ERROR: Error: Actor not in scroll view
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], ---
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], sendMove) right ctrl: false
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], sendMove) curMonitor: {"monitorIndex":0,"x":72,"y":27,"width":1848,"height":1026,"leftEd ge":72,"rightEdge":1920,"topEdge":27,"bottomEdge":1053,"isPortrait":false,"isNotUltrawide":true,"colCount":2,"rowCount":2}
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], sendMove) monitorToLeft: -1 monitorToRight: -1
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], sendMove) Already in a tile.
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], sendMove) {"origFrame":{"x":122,"y":1517,"width":496,"height":349},"row":0,"col":0,"heig ht":2,"width":1}
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], sendMove) right
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], sendMove) right - move
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], moveApp) {"row":0,"col":1,"height":2,"width":1}
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], moveApp) monitor: {"monitorIndex":0,"x":72,"y":27,"width":1848,"height":1026,"leftEdge": 72,"rightEdge":1920,"topEdge":27,"bottomEdge":1053,"isPortrait":false,"isNotUltrawide":true,"colCount":2,"rowCount":2}
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], moveAppCoordinates) Moving window to (996,27), size (924,1026) with 0px gaps
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], moveApp) window wider than anticipated. Shift left by -2 px
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], moveAppCoordinates) Moving window to (998,27), size (922,1026) with 0px gaps
     1 Mär 11 21:53:58 hostname gnome-shell[3734]: [WinTile], moveApp) window.x: 996 window.y: 27 window.width: 922 window.height: 1025
     1 Mär 11 21:53:59 hostname gnome-shell[3734]: [WinTile], ---

@GrylledCheez
Copy link
Collaborator

GrylledCheez commented Mar 11, 2024 via email

@GrylledCheez
Copy link
Collaborator

super-left and -right keys maximize the window in single column mode.

That's intended behavior for all column counts and row counts. It only looks weird because you're using single column mode.

@Marwe
Copy link
Author

Marwe commented Mar 12, 2024

I installed via extensions.gnome.org and cannot find a version number.
The JS errors may be gnome related, not necessarily in the scope of the extension? Though the log is a wintile log...

The single column issue mentioned was only due to an unexpected config change, it does not matter and works as expected. I might accidentally have changed the columns with the arrow keys in the config (my guess).

@Marwe
Copy link
Author

Marwe commented Mar 18, 2024

Hm, it seems to be related to display changes, plugging USB3/thunderbolt off or on can trigger it (happened multiple times today - without logging). However, I found this alias in my config to quickly reload wintile from cli :)

alias wintile='gnome-extensions disable wintile@nowsci.com;gnome-extensions enable wintile@nowsci.com'

@GrylledCheez
Copy link
Collaborator

Wintile doesn't have logging of its own. It sends logs to journald that start with "[Wintile]" , and we are merely grepping for that string in the command on the README.MD

Wintile can't emit anything about the USB.

@gazhay
Copy link

gazhay commented Apr 8, 2024 •
edited
Loading

I have had intermittent problems over a few years with the hotkeys stopping working.

I used to have a script which ran when I woke the screen to disable and reenable wintile and that fixed it.
You could also bind a script to a key for the same purpose

e.g.

gnome-extensions disable wintile@nowsci.com
sleep 2
gnome-extensions enable wintile@nowsci.com

@Marwe
Copy link
Author

Marwe commented Apr 10, 2024

@gazhay where is and what would be a proper hook? "screen wakeup"/"recover from suspend" or "display setup changed" come to my mind, I did not find one yet, therefore defined the alias.

I lately found in that situation gnome-shell throwing lots of messages into logging with scrollView.vscroll is null and more, the logging alone needed a hell of resources.
I have another alias to restart the gnome-shell (works from a terminal session, too):
alias gnomeshellrestart='echo "gnome-shell --replace -d" $(w| grep "$USER"| awk "{print \$3}"|grep ":"|head -1)| at now'

@iaakki
Copy link

iaakki commented Aug 29, 2024

I just open the Extensions in ubuntu, disable all extensions from that single switch and then enable again. Then tiling shortcuts works again. Ubuntu 22.04 and yes I use a tb-dock. This is a very annoying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gazhay @Marwe @GrylledCheez @iaakki