Update to Gnome45 #166
Update to Gnome45 #166
Conversation
|
@gilvbp, do we need keybindings.js at all? And eslint is complaining about your use of import and export. But that might just be that we need a newer eslintrc.yml |
extension.js
Outdated
| extdatadir: imports.misc.extensionUtils.getCurrentExtension().path, | ||
| shell_version: parseInt(Config.PACKAGE_VERSION.split('.')[1], 10), | ||
| extdatadir: Extension.path, | ||
| // shell_version: parseInt(Config.PACKAGE_VERSION.split('.')[1], 10), |
There was a problem hiding this comment.
Did you remove the version check because it's only for v45, or because the version string isn't there?
Yes, we need. We have to change the eslintrc.yml to accept new ecma import type. |
sourceType: module
|
@gilvbp, use the latest .eslintrc.yml I pushed to your repo, then run eslint with --fix as described in CONTRIBUTING.md |
|
That fixes the style issues! I don't have anything with Gnome 45 right now. So just do the following checks and I'll sign off on the PR. Perform these tests in both landscape and portrait
|
I won't be able to test the last 2 tests because pref.js still doesn't work (I described it on PR request). I need help with that. |
|
If you want, I'll accept this partial PR while you try and get this working. But we aren't going to release until the prefs.js works, But here's the preferences guide for 45. |
|
Please accept this partial PR. "The user interface will be created with GTK4 and Adwaita, which has many elements specifically for settings and configuration."# The problem is that the new gtk4 widget changed a lot of layout attributes, as you can see here (https://docs.gtk.org/gtk4/class.Widget.html) and here: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.PreferencesGroup.html) |
|
Great work. I'll see what I can learn this weekend. Make sure you update the README to say that this is only for 45, and to give yourself credit. |
|
Hi there. I am a typescript developer and can help with this PR if needed. Migrated to latest fedora with gnome 45 and without this extension it doesnt feel good to use it. So I can both test or do smth else. Tried to write a new PR by myself but it is not that comfortable to debug what is wrong with extension changes |
|
@atassis, take a look at some of the groundwork I started in the develop branch instead of this PR. |
Update to Gnome45.
TO-DO on prefs.js needs to update the widget with the new adw.PreferencesGroup layout attributes