-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoding problems when running the cli
tests on Windows
#207
Comments
cli
tests on Windowscli
tests on Windows
After updating the following line:
|
@Jrfidellis When you create a new project and run |
If it is, then there is probably no changes to do with the code. I guess that the issue comes from how git clones the repository to your host (Windows). It may automatically convert the line endings I created a new branch Resources |
It doesn't seems to work 😞 PS: the only change i did in the code was replacing the |
Hmm it's weird, I just tried on Windows and it is working fine for me. It is maybe my fault, I told you to pull the branch and directly run the tests. Replacing Note: I'm not sure that |
I tested it again and it's working properly, thank you. I did replace the I tested without |
Great! 💃 Do you want to submit a PR on that? The new branch should be created from Regarding the environment variable problem, a workaround to make it both work on Windows and Unix systems is to use the
|
Hi @LoicPoullain, I opened a pull request with the changes that you proposed. The Travis build isn't passing because of a missing newline in the 'test.ts' file. Unfortunately i had to delete my fork repository and i can't add the newline to the PR (it's my first time working with forks and things got a little messy there, so i deleted the old one and did a fresh fork). |
Hi @Jrfidellis , Thanks for submitting the PR. I guess that this one cannot be modified anymore since the "compare" branch no longer exists (the old fork has been deleted). The only solution that I see here is to recreate a new branch from your fresh fork and submit a new PR. If you have other problems while working with forks in the future, don't hesitate to tell me, maybe I can help! Regarding the missing newline error, it is due to the rules I defined with TSLint. You can configure VSCode to highlight these errors when writing code and even fix them when saving your files. I wrote a small tuto in the docs on how to do that. |
Fixed in v0.6.0 |
Issue
Issue reported in the PR #206. When running the tests of the
cli
package on Windows, they all seem to fail because of a line break encoding (\n
vs\r\n
).Possible solutions
OR
test-environment.ts
to replace all\r\n
characters by\n
when loading a generated file during tests (maybe easier).The text was updated successfully, but these errors were encountered: