Correcting typeorm scripts - Issue #204

[Jrfidellis]

Issue

Fix #204.

Solution and steps

• Remove ts-node dependency.
• Update the migration commands.

Checklist

• Add/update/check docs.
• Add/update/check tests.
• Update/check the cli generators.

[LoicPoullain]

Hi @Jrfidellis ,

Thanks for submitting this PR. I added some comments in the description to improve its traceability.

The examples package is just a place I use to do some manual tests. It does not contain the templates used to generate the app when running the command foal createapp. These templates are actually located in the cli package. Here’s how it is organized:

src
'- generate # Handles the commands `foal createapp` and `foal generate`
  |- generators # Contains the code which renders the templates or updates the files
  |- mocks # Contains some pieces of code used to test the file "updaters"
  |- specs # Defines how the generated files should look like in different scenarios (specifications)
  |- templates # Contains the actual templates used to generate the files
  '- utils # Contains some helpers shared by all the generators

Updating the examples package is therefore necessary but we also need to update the package.json files located in specs and templates. Once done you can run the generators tests with the command npm run dev:test:generators at the path packages/cli (they will be executed in the Github hook anyway).

If you encounter problems let me know! 😉

[Jrfidellis]

@LoicPoullain, i wasn't able to run the tests, maybe because of the Issue #187?

All the errors (39 in total) look like this one:

 34) createService when the directory / exists should render the authenticator templates in the proper directory.:

      AssertionError [ERR_ASSERTION]: 'export { BarFoo } from \'./bar-foo.service\';\r\nexport { TestFooBar } from \'./test-foo-bar.service\';\n' === 'export { BarFoo } from \'./bar-foo.service\';\r\nexport { TestFooBar } from \'./test-foo-bar.service\';\r\n'
      + expected - actual

       export { BarFoo } from './bar-foo.service';
      -export { TestFooBar } from './test-foo-bar.service';
      +export { TestFooBar } from './test-foo-bar.service';

[LoicPoullain]

LGTM 👍

[LoicPoullain]

Hmm, ok so the tests are running properly in the travis build anyway: https://travis-ci.org/FoalTS/foal/builds/425373591?utm_source=github_status&utm_medium=notification. So the PR is good.

I guess that your issue is related to how Windows and Unix systems (Mac OS, Linux) handle differently line breaks. Depending on the OS sometimes they have different encodings: \n, \r or \r\n.

What makes me think of that is that the two compared strings look exactly the same but they actually end with a different character: \n and \r\n.