Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Social Auth] Improve social errors. #584

Merged
merged 3 commits into from
Dec 4, 2019
Merged

[Social Auth] Improve social errors. #584

merged 3 commits into from
Dec 4, 2019

Conversation

LoicPoullain
Copy link
Member

Issue

Fixes #582

Solution and steps

  • Improve the errors.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #584 into v1-3-1 will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-3-1     #584      +/-   ##
==========================================
- Coverage   99.57%   99.49%   -0.08%     
==========================================
  Files          88       88              
  Lines        1635     1587      -48     
  Branches      373      341      -32     
==========================================
- Hits         1628     1579      -49     
- Misses          7        8       +1
Impacted Files Coverage Δ
packages/core/src/express/create-app.ts 97.46% <0%> (-1.37%) ⬇️
packages/core/src/common/utils/controller.util.ts 100% <0%> (ø) ⬆️
...ages/core/src/common/utils/verify-password.util.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-optional.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-required.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/set-session-cookie.ts 100% <0%> (ø) ⬆️
...api/metadata-getters/get-api-complete-operation.ts 100% <0%> (ø) ⬆️
packages/core/src/express/create-middleware.ts 100% <0%> (ø) ⬆️
packages/core/src/express/handle-errors.ts 100% <0%> (ø) ⬆️
...ackages/core/src/sessions/remove-session-cookie.ts 100% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a0443...8b656a0. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 145b6b0 into v1-3-1 Dec 4, 2019
@LoicPoullain LoicPoullain deleted the social-errors branch December 4, 2019 18:02
@LoicPoullain LoicPoullain mentioned this pull request Dec 4, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant