Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Social auth] Add Github and LinkedIn providers #591

Merged
merged 13 commits into from
Dec 12, 2019

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Dec 10, 2019

Issue

See #125, #581

Solution and steps

  • Add Github provider.
  • Test Github provider in @foal/examples.
  • Add LinkedIn provider.
  • Test LinkedIn provider in @foal/examples.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain changed the base branch from master to v1-4-0 December 10, 2019 19:03
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #591 into v1-4-0 will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-4-0     #591      +/-   ##
==========================================
- Coverage   99.49%   99.16%   -0.33%     
==========================================
  Files          88       65      -23     
  Lines        1587     1083     -504     
  Branches      341      266      -75     
==========================================
- Hits         1579     1074     -505     
- Misses          8        9       +1
Impacted Files Coverage Δ
packages/core/src/common/hooks/log.hook.ts 66.66% <0%> (-33.34%) ⬇️
packages/core/src/express/handle-errors.ts 75% <0%> (-25%) ⬇️
packages/core/src/express/create-app.ts 95.83% <0%> (-1.64%) ⬇️
.../src/openapi/metadata-getters/get-api-used-tags.ts 100% <0%> (ø) ⬆️
...ages/core/src/common/tokens/generate-token.util.ts 100% <0%> (ø) ⬆️
packages/core/src/openapi/utils/merge-tags.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-required.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/common/utils/escape.ts 100% <0%> (ø) ⬆️
...ackages/core/src/sessions/remove-session-cookie.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/set-session-cookie.ts 100% <0%> (ø) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934c98c...1ea6dc0. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 385ec97 into v1-4-0 Dec 12, 2019
@LoicPoullain LoicPoullain deleted the twitter-linkedin-github branch December 12, 2019 09:11
@LoicPoullain LoicPoullain mentioned this pull request Dec 12, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant