Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL] Make TypeGraphQL a dev dep #608

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

LoicPoullain
Copy link
Member

Issue

Version 1.3.1 added type-graphql by mistake as dependency of the @foal/graphql package.

Solution and steps

  • Make it a dev dependency.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #608 into v1-4-0 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-4-0     #608      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files          90       90              
  Lines        1632     1589      -43     
  Branches      364      335      -29     
==========================================
- Hits         1626     1583      -43     
  Misses          6        6
Impacted Files Coverage Δ
packages/core/src/common/utils/controller.util.ts 100% <0%> (ø) ⬆️
...ages/core/src/common/utils/verify-password.util.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-optional.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-required.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/set-session-cookie.ts 100% <0%> (ø) ⬆️
...api/metadata-getters/get-api-complete-operation.ts 100% <0%> (ø) ⬆️
packages/core/src/express/create-app.ts 100% <0%> (ø) ⬆️
packages/core/src/express/send-response.ts 100% <0%> (ø) ⬆️
...ackages/core/src/sessions/remove-session-cookie.ts 100% <0%> (ø) ⬆️
packages/core/src/core/routes/utils.ts 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4802007...06d34df. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 883ef93 into v1-4-0 Jan 6, 2020
@LoicPoullain LoicPoullain deleted the type-graphql-dev-dep branch January 6, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant