Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Remove wrong npm naming control #610

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

The createapp command checks the name of the project to see if it fits the (alleged) npm naming conventions. The code is wrong (@ and / are valid for example) and this feature is not really useful.

Solution and steps

  • Remove this.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain changed the title Remove npm naming conventions [CLI] Remove wrong npm naming control Jan 6, 2020
@LoicPoullain LoicPoullain mentioned this pull request Jan 6, 2020
9 tasks
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #610 into v1-4-0 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-4-0     #610      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +<.01%     
==========================================
  Files          90       90              
  Lines        1589     1632      +43     
  Branches      335      364      +29     
==========================================
+ Hits         1583     1626      +43     
  Misses          6        6
Impacted Files Coverage Δ
packages/core/src/common/utils/controller.util.ts 100% <0%> (ø) ⬆️
...ages/core/src/common/utils/verify-password.util.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-optional.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-required.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/set-session-cookie.ts 100% <0%> (ø) ⬆️
...api/metadata-getters/get-api-complete-operation.ts 100% <0%> (ø) ⬆️
packages/core/src/express/create-app.ts 100% <0%> (ø) ⬆️
packages/core/src/express/send-response.ts 100% <0%> (ø) ⬆️
...ackages/core/src/sessions/remove-session-cookie.ts 100% <0%> (ø) ⬆️
packages/core/src/core/routes/utils.ts 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65086a...5f75b1b. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 09d0a9f into v1-4-0 Jan 6, 2020
@LoicPoullain LoicPoullain deleted the remove-npm-naming-convetions branch January 6, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant