Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserWithPermissions extends BaseEntity and new UserWithPermissions.withPerm static method #682

Merged
merged 6 commits into from
Apr 26, 2020

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Apr 25, 2020

Issue

Resolves #656
Resolves #637

Solution and steps

  • Extend UserWithPermissions with BaseEntity
  • Add UserWithPermissions.withPerm
  • Enhance Permission, Group and UserWithPermissions tests with several databases

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #682 into v1-8-0 will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-8-0     #682      +/-   ##
==========================================
- Coverage   99.64%   99.41%   -0.24%     
==========================================
  Files          94       70      -24     
  Lines        1700     1192     -508     
  Branches      399      302      -97     
==========================================
- Hits         1694     1185     -509     
- Misses          6        7       +1     
Impacted Files Coverage Δ
packages/core/src/common/hooks/log.hook.ts 66.66% <0.00%> (-33.34%) ⬇️
packages/core/src/core/config/utils.ts 100.00% <0.00%> (ø)
packages/core/src/core/routes/utils.ts 100.00% <0.00%> (ø)
packages/core/src/express/not-found.ts 100.00% <0.00%> (ø)
packages/core/src/express/create-app.ts 100.00% <0.00%> (ø)
packages/core/src/sessions/constants.ts 100.00% <0.00%> (ø)
packages/core/src/express/send-response.ts 100.00% <0.00%> (ø)
packages/core/src/core/http/http-methods.ts 100.00% <0.00%> (ø)
packages/core/src/common/utils/escape-prop.ts 100.00% <0.00%> (ø)
packages/core/src/common/utils/render.util.ts 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af98a9...32d216e. Read the comment docs.

@@ -13,7 +13,7 @@ services:
MYSQL_DATABASE: "test"

mariadb:
image: "mariadb:10.1.16"
image: "mariadb:10.3.22"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LoicPoullain LoicPoullain merged commit 04ed6aa into v1-8-0 Apr 26, 2020
@LoicPoullain LoicPoullain deleted the permissions-base-entity branch April 26, 2020 09:57
@LoicPoullain LoicPoullain mentioned this pull request Apr 26, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant