Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mongoose types #688

Merged
merged 4 commits into from
May 1, 2020
Merged

Remove mongoose types #688

merged 4 commits into from
May 1, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

Fixes #687.

A recent change on the @types/mongodb package made the build to fail. We had a lot of these issues in the past with different @types packages.

To fix this, @types/mongodb and @types/mongoose are removed from @foal packages. This introduces some any in function parameters or return values but does not add breaking changes (any can be assigned to anything and anything can be assign to any).

People using Foal still have the possibility to install @types/mongodb and @types/mongoose if they want to use them.

Solution and steps

  • Uninstall @types/mongodb
  • Uninstall @types/mongoose
  • Do not install and use by default @types/mongoose in the generators

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain merged commit c5c744a into v1-8-1 May 1, 2020
@LoicPoullain LoicPoullain deleted the remove-mongoose-types branch May 1, 2020 09:54
@LoicPoullain LoicPoullain mentioned this pull request May 1, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant