Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix http-responses typo mistakes #722

Merged
merged 3 commits into from
May 25, 2020
Merged

fix http-responses typo mistakes #722

merged 3 commits into from
May 25, 2020

Conversation

AminTaghikhani
Copy link
Contributor

@AminTaghikhani AminTaghikhani commented May 25, 2020 •
edited by LoicPoullain
Loading

Issue

Solution and steps

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain self-requested a review May 25, 2020 06:24
@LoicPoullain LoicPoullain changed the base branch from master to v1-9-0 May 25, 2020 06:38
@LoicPoullain LoicPoullain changed the base branch from v1-9-0 to master May 25, 2020 06:41
@LoicPoullain LoicPoullain changed the base branch from master to v1-9-0 May 25, 2020 06:41
LoicPoullain
LoicPoullain approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@LoicPoullain LoicPoullain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thks 👍

The forceDownload option was working properly on Chrome but not on Safari. It looks like Chrome considers any other value of Content-Disposition as not inline.

@LoicPoullain LoicPoullain merged commit 28e0101 into FoalTS:v1-9-0 May 25, 2020
@LoicPoullain LoicPoullain mentioned this pull request May 25, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoicPoullain LoicPoullain LoicPoullain approved these changes

Assignees

@AminTaghikhani AminTaghikhani

Labels
bug enhancement
Projects
Issue tracking
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AminTaghikhani @LoicPoullain