Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Catch rejected promises in shell scripts #762

Merged
merged 1 commit into from
Jul 16, 2020
Merged

[CLI] Catch rejected promises in shell scripts #762

merged 1 commit into from
Jul 16, 2020

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Jul 16, 2020 •
edited
Loading

Issue

Fixes #671

Solution and steps

  • Add a try/catch

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Jul 16, 2020
Merged
5 tasks
@LoicPoullain LoicPoullain merged commit bf38c63 into v1-10-0 Jul 16, 2020
@LoicPoullain LoicPoullain deleted the catch-script-promises branch July 16, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
Issue tracking
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LoicPoullain