Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Support sub-paths in generate rest-api #878

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Feb 8, 2021

Issue

Resolves #862.

Solution and steps

  • Refactor createController tests.
  • Refactor createRestApi tests.
  • Allow sub-paths in createRestApi.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Feb 8, 2021
4 tasks
@codecov-io
Copy link

Codecov Report

Merging #878 (1165c76) into v2-2-0 (cc40822) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v2-2-0     #878   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          82       82           
  Lines        1654     1654           
  Branches      398      398           
=======================================
  Hits         1636     1636           
  Misses         18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc40822...1165c76. Read the comment docs.

@LoicPoullain LoicPoullain merged commit ba1aeb6 into v2-2-0 Feb 9, 2021
@LoicPoullain LoicPoullain deleted the g-rest-api-subdir branch February 9, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants