-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Decorating existing method #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so given
is this still a work in progress? |
Ahhh... Sorry about that... Not work in progress, the latest force push
solves those issues.
There are unit test cases for those as well now. Enjoy the extra features.
Now working on adding Roslyn Analysers for RxUI.Fody, to flag a few issues
I found.
…On Sun, 4 Aug 2019, 08:39 Simon Cropp, ***@***.***> wrote:
so given
Does not support async await.
Perhaps does not support Lambdas.
is this still a work in progress?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#69?email_source=notifications&email_token=AA46MLIH2NIG4RV4D4VFAB3QCYQKHA5CNFSM4IFPMQVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PYFEQ#issuecomment-517964434>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA46MLM6MF5547WPQM37C4DQCYQKHANCNFSM4IFPMQVA>
.
|
Hey Simon, this PR is ready to merge. |
Can u add some doco to the readme |
Sure...:)
…On Sat, 10 Aug 2019, 05:46 Simon Cropp, ***@***.***> wrote:
Can u add some doco to the readme
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#69?email_source=notifications&email_token=AA46MLLSZYHZEED7SSRZ4GTQDXQVDA5CNFSM4IFPMQVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD373JRI#issuecomment-520074437>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA46MLN3QTAJNO2CDT5HZLDQDXQVDANCNFSM4IFPMQVA>
.
|
Done |
@arontsang thanks for this. it is now deployed to nuget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Decorator style replacement.
Bugs.
Does not support async await.
Perhaps does not support Lambdas.
Working to support other types of generator pattern types.