Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add game loader screen #68

Merged
merged 39 commits into from
May 28, 2023
Merged

Add game loader screen #68

merged 39 commits into from
May 28, 2023

Conversation

ForNeVeR
Copy link
Owner

@ForNeVeR ForNeVeR commented Apr 10, 2023 •
edited
Loading

Closes #13.
Should close #92.

TODO

  • Loader animation
  • Run tests on CI
  • Finish the loading scene and show it on the start
  • Pack loader resources properly (.svg → .png on build)
  • Add logic to download resources on startup, wire with preloader
  • Add logic to use already loaded resources on startup
  • Rebase onto main
  • Add disclaimer text (in English for now in all supported languages)
  • Check the issues we're claiming to close: there should be no leftover TODOs
  • Ensure we truly unblock Async level initialization #47
  • Migrate everything to Tasks
    • Check that we properly switch to the thread pool
  • Localize everything
  • Final UI sweep

Before merge

  • TODO sweep

After merge

  • Unblock Async level initialization #47
  • Raise an issue on local game config file (with data location)
    • Drop command line argument for resource location
    • Allow to override config via environment
    • Remove the launchSettings.json from .gitignore (it should no longer be required to pass any non-shareable parameters there)

@ForNeVeR ForNeVeR self-assigned this Apr 10, 2023
@ForNeVeR ForNeVeR mentioned this pull request May 14, 2023
Open
Atomosk and others added 2 commits May 22, 2023 20:15
@Atomosk
Micro optimization.
5cd0a7d
@ForNeVeR
Merge branch 'main' into feature/13.downloader
f73c989 
# Conflicts:
#	O21.Game/Content.fs
#	O21.Game/O21.Game.fsproj
#	O21.Game/O21Game.fs
#	O21.Game/Program.fs
#	O21.Game/U95/U95Data.fs
@ForNeVeR ForNeVeR mentioned this pull request May 27, 2023
Closed
@ForNeVeR
Copy link
Owner Author

@kant2002, could you please take a look at the Ukrainian translation I've managed to prepare using ChatGPT and Google Translate?

@ForNeVeR ForNeVeR marked this pull request as ready for review May 27, 2023 20:53
ForNeVeR
ForNeVeR commented May 27, 2023
View reviewed changes
O21.Game/Downloader.fs Outdated Show resolved Hide resolved
O21.Game/Downloader.fs Show resolved Hide resolved
O21.Game/Downloader.fs Outdated Show resolved Hide resolved
O21.Game/Downloader.fs Outdated Show resolved Hide resolved
ForNeVeR
ForNeVeR commented May 28, 2023
View reviewed changes
O21.Game/Loading/LoadingLoop.fs Outdated Show resolved Hide resolved
O21.Game/Loading/LoadingLoop.fs Outdated Show resolved Hide resolved
O21.Game/Loading/LoadingLoop.fs Show resolved Hide resolved
O21.Game/Loading/LoadingSceneBase.fs Outdated Show resolved Hide resolved
O21.Game/Program.fs Outdated Show resolved Hide resolved
O21.Game/U95/U95Data.fs Outdated Show resolved Hide resolved
@ForNeVeR ForNeVeR merged commit e786c9b into main May 28, 2023
@ForNeVeR ForNeVeR deleted the feature/13.downloader branch May 28, 2023 12:50
@ForNeVeR ForNeVeR mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kant2002 kant2002 kant2002 left review comments

Assignees

@ForNeVeR ForNeVeR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decoding Cyrillic characters in path Auto-downloader of the game files
3 participants
@ForNeVeR @kant2002 @Atomosk