fix: incorrect mongoose type used for ConnectOptions #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FTheron
changed the title
Thenkei
approved these changes
May 7, 2024
|
Can you amend the commit to use the same message you used in the PR title? The current CI is not ideal, because it checks every commit to verify they're following the conventional commit convention. This will allow us to run the CI on your PR. |
forest-bot
added a commit
that referenced
this pull request
May 13, 2024
## [9.3.22](v9.3.21...v9.3.22) (2024-05-13) ### Bug Fixes * incorrect mongoose type used for ConnectOptions ([#1101](#1101)) ([290276a](290276a))
|
🎉 This PR is included in version 9.3.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
Building forest-admin projects with typescript should not fail.
Error:
'"mongoose"' has no exported member named 'ConnectionOptions'. Did you mean 'ConnectOptions'?General
This is a typing issue I detected when using typescript in our builds. Mongoose does not export type
ConnectionOptions. It should beConnectOptions.Security
No impact
PS: Adding
"skipLibCheck": truein ourtsconfigworks as a temporary workaround.