Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): add proxy methods to improve the agent customization #16

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

nicolasalexandre9
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

}

private function loadOptions(): array
public function addChart(string $name, \Closure $definition): self
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

$this->agent->build();
}

public function customizeCollection(string $name, \Closure $handle): self
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Apr 14, 2023

Code Climate has analyzed commit 2572498 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (99% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@nicolasalexandre9 nicolasalexandre9 merged commit 2984207 into beta Apr 14, 2023
forest-bot added a commit that referenced this pull request Apr 14, 2023
# [1.0.0-beta.11](v1.0.0-beta.10...v1.0.0-beta.11) (2023-04-14)

### Features

* **agent:** add proxy methods to improve the agent customization ([#16](#16)) ([2984207](2984207))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@nicolasalexandre9 nicolasalexandre9 deleted the feat/add-proxy-functions branch April 14, 2023 14:37
forest-bot added a commit that referenced this pull request Jun 19, 2023
# 1.0.0 (2023-06-19)

### Bug Fixes

* **config:** allow packages versions for symfony 6 ([#13](#13)) ([e5c4d09](e5c4d09))
* config setup onboarding([#9](#9)) ([0e246ae](0e246ae))
* **onboarding:** set forest_server_url into .env during install  ([#8](#8)) ([d06c979](d06c979))
* add clear cache on forest install command ([#7](#7)) ([82e799d](82e799d))

### Features

* update composer with the new dependencies of the monorepo agent-php ([#19](#19)) ([efa7e29](efa7e29))
* **agent:** add proxy methods to improve the agent customization ([#16](#16)) ([2984207](2984207))
* **agent:** add service and cors options ([#2](#2)) ([88f1274](88f1274))
* **command:** add new install command & update config options ([#4](#4)) ([c9fc878](c9fc878))
* **plugin:** allow agent to handle plugin ([#18](#18)) ([f6837e6](f6837e6))
* update composer.json to enable agent for symfony 5.4 ([#11](#11)) ([008668c](008668c))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants