-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Binnie's hive generation to the Forestry HiveRegistry #486
Conversation
if (isValidLocation(world, pos)) { | ||
return pos; | ||
} | ||
pos.add(0, -1, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strategy here will check every block from the surface down to 0.
A more efficient strategy would be to get the topPos
and try a few random locations between 0 and topPos
.
Only try a few locations before giving up.
Still needs tweaks to get worldgen to previous levels. Also, the rate registered with forestry should depend on the config settings for extrabees. |
Using Debug Hives config option and World Stripper mod makes this pretty easy.
} | ||
|
||
@Override | ||
public boolean isGoodBiome(Biome biome) { | ||
if (hiveType == EnumHiveType.NETHER) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can simplify this
return hiveType != EnumHiveType.NETHER
|| BiomeDictionary.hasType(biome, BiomeDictionary.Type.NETHER);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
still not sure if rates are right
I'm still not sure if the rates are right. Also, I think marble hives were designed for Red Power 2 marble so don't generate as frequently on chisel marble. I will include some issues I think this resolves: |
Whenever I've done tweaks to hive generation, I add some debug logging for how many of each hive are placed. |
|
@AnrDaemon He talks about trees from extra trees. |
@temp1011 What's the current state of this PR ? |
I haven't looked at it in a while sorry. I need to test the numbers to make sure everything works the same. Not sure how good this is for performance as well. |
Oh great though I just couldn't find them, turns out they weren't generating at all to begin with |
The bee effect coming off the hives is the wrong colour at the moment too (I get forest bees for rocky hives). |
I can hopefully get this done this Sunday. At the moment it's difficult for me to test it though. |
@temp1011 Any update ? |
I believe this needs ForestryMC/ForestryMC#2204 to work well, but I haven't looked at this in a while. |
See new PR |
Adds Binnie hive generation to forestry
HiveRegistry
so that binnie hives will obey forestry configs (eg - for dimension blacklisting.Still TODO:
- figure out why this seems to get stuck sometimes- expose getting the instance ofHiveRegistry
in Forestry- Make this faster (worldgen is very slow).Hopefully it is possible to do this without it being too slow. I'm sure there's a lot that can be done to help that. I'm probably misusing
IHivegen
at the moment.