Add Interceptor support for PUSH_REGISTER and PUSH_AUTHENTICATE Action types #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahancouver
requested review from
spetrov,
jeyanthanperiyasamy,
rodrigoareis and
george-bafaloukas-forgerock
| class PushRequestInterceptor: RequestInterceptor { | ||
| func intercept(request: Request, action: Action) -> Request { | ||
| if action.type == "PUSH_REGISTER" { | ||
| RequestInterceptorTests.intercepted.append("PUSH_REGISTER") |
There was a problem hiding this comment.
as an extra step in the test, i think we can add some custom header in request and add those custom header part of AM_Push_Registration_Successful mocks to make sure the request has custom header .
There was a problem hiding this comment.
Updated the tests. added custom header to the request.
jeyanthanperiyasamy
requested changes
Jun 27, 2023
Updated the test to use more generic handleNotification method that is called for accepting/denying all types of push notifications |
jeyanthanperiyasamy
approved these changes
Jun 28, 2023
rodrigoareis
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDKS-2545
Add Interceptor support for PUSH_REGISTER and PUSH_AUTHENTICATE Action types
Add unit tests