Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOTEDGE-1208 Add JWT client assertion authentication support #154

Merged
merged 1 commit into from
Jan 13, 2022
Merged

IOTEDGE-1208 Add JWT client assertion authentication support #154

merged 1 commit into from
Jan 13, 2022

Conversation

JacoJooste
Copy link
Collaborator

This change includes:

  • seamless handling of authentication method requested via callback (jwt-pop-authentication or client_assertion)
  • functional test for JWT bearer authentication
  • functional test for unrestricted sessions
  • updates to both standalone and forgeops functional tests

LimaEchoCharlie
LimaEchoCharlie reviewed Jan 13, 2022
View reviewed changes
pkg/callback/callbacks.go
Aud string `json:"aud"`
ThingType ThingType `json:"thingType"`
ThingType ThingType `json:"thingType,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I think adding omitempty to more fields in our message structs will result in a noticeable reduction in message size. We have added it to a lot of fields but when I did my last analysis, I noticed a few that have been missed.

LimaEchoCharlie
LimaEchoCharlie reviewed Jan 13, 2022
View reviewed changes
tests/internal/anvil/framework.go
realm string
realmPath string
amURL *url.URL
dnsConfigured bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is great improvement over the previous interface implementation, it is a lot cleaner.

LimaEchoCharlie
LimaEchoCharlie approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@LimaEchoCharlie LimaEchoCharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@JacoJooste JacoJooste merged commit 0696642 into main Jan 13, 2022
@JacoJooste JacoJooste deleted the client-assertion-auth branch January 13, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LimaEchoCharlie LimaEchoCharlie LimaEchoCharlie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacoJooste @LimaEchoCharlie