IOTEDGE-1205 Add IG as API Gateway [WIP] #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacoJooste
approved these changes
Nov 17, 2022
| @@ -65,7 +65,9 @@ export CLUSTER=<The cluster name> | |||
| export ZONE=<The Google Cloud zone in which the cluster resides> | |||
| export NAMESPACE=<The namespace to use in your cluster> | |||
| export FQDN=<The fully qualified domain name of your deployment> | |||
| export CONTAINER_REGISTRY=<The default container repository> | |||
There was a problem hiding this comment.
Suggested change
| export CONTAINER_REGISTRY=<The default container repository> | |
| export CONTAINER_REGISTRY=<The default container registry> |
| ./forgeops build am --config-profile $CONFIG_PROFILE | ||
| ./forgeops build idm --config-profile $CONFIG_PROFILE | ||
| ./forgeops build am --config-profile $CONFIG_PROFILE --default-repo $CONTAINER_REGISTRY | ||
| ./forgeops build idm --config-profile $CONFIG_PROFILE --default-repo $CONTAINER_REGISTRY |
There was a problem hiding this comment.
Can you please add CONTAINER_REGISTRY to the:
- check on line 25 of this file
- env print out on line 47 of this file
- env list on line 19 of
deployments/forgeops/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.