Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Add --queue, --buffer flags, default options and args tests. #43

Merged
merged 2 commits into from
Dec 8, 2015

Conversation

ryan-roemer
Copy link
Member

  • Add --queue=NUM flag to 'concurrent'
  • Add --buffer flag to 'concurrent'
  • Add default options to flags in 'args'
  • Add basic unit tests for 'args' parsing logic
  • Add infrastructure for sinon, mocha, chai, karma
  • Hook up Travis to coveralls for coverage reports
  • Update README docs
  • Add 'LOCAL_DEV' env variable option for 'npm link' local development
  • BUGFIX: Make displayHelp() show unique tasks.

/cc @chaseadamsio @exogen @aisapatino

@ryan-roemer ryan-roemer changed the title Add --queue flag, default options and args tests. Add --queue, --buffer flags, default options and args tests. Dec 7, 2015
* Add --queue=NUM flag to 'concurrent'
* Add --buffer flag to 'concurrent'
* Add default options to flags in 'args'
* Add basic unit tests for 'args' parsing logic
* Add infrastructure for sinon, mocha, chai, karma
* Hook up Travis to coveralls for coverage reports
* Update README docs
* Add 'LOCAL_DEV' env variable option for 'npm link' local development
* BUGFIX: Make displayHelp() show unique tasks.

```sh
$ builder run foo-task
$ builder run TASK

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's common to use angle brackets around the term that should be interchangeable in a lot of documentation: <TASK>

Might be worthwhile to do that here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaseadamsio 👍 Both git and npm follow this convention, as minor as it is, I'd lean towards copying them. builder run <task>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@exogen
Copy link
Contributor

exogen commented Dec 8, 2015

Minor comments but LGTM 👍

ryan-roemer added a commit that referenced this pull request Dec 8, 2015
Add --queue, --buffer flags, default options and args tests.
@ryan-roemer ryan-roemer merged commit ac9c126 into master Dec 8, 2015
@ryan-roemer ryan-roemer deleted the chore-queue branch December 8, 2015 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants