Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Enhancement: Add ES and UMD builds #94

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Enhancement: Add ES and UMD builds #94

merged 2 commits into from
Feb 13, 2018

Conversation

ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Jan 26, 2018

With the UMD build both prop-types and react are expected to be available on the global object before Freactal is loading. Since both of those packages have UMD builds, this should be fine.


The maintainers of this repo require that all pull request submitters adhere to the following:

  • I have read and will comply with the contribution guidelines.
    (required)
  • I have read and will comply with the code of conduct.
    (required)
  • All related documentation has been updated to reflect the changes made. (required)
  • My commit messages are cleaned up and ready to merge. (required)

The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent. Please select one of the following:

  • major
  • minor
  • patch
  • documentation only

@maintainerd
Copy link

maintainerd bot commented Jan 26, 2018

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.


Click to view log...

  • 2018-01-26T17:15:21.792Z:af63bed: The pull request was created
  • 2018-01-26T17:15:38.778Z:af63bed: @ryan-roemer checked I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md)..
  • 2018-01-26T17:15:39.294Z:af63bed: @ryan-roemer checked I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md)..
  • 2018-01-26T17:15:40.439Z:af63bed: @ryan-roemer checked All related documentation has been updated to reflect the changes made. _(required)_.
  • 2018-01-26T17:15:43.698Z:af63bed: @ryan-roemer checked My commit messages are cleaned up and ready to merge. _(required)_.
  • 2018-01-26T17:16:36.387Z:af63bed: @ryan-roemer selected minor as the semantic version.

@divmain divmain merged commit 4151453 into master Feb 13, 2018
@divmain
Copy link
Contributor

divmain commented Feb 13, 2018

maintainerd is still acting up - I'm force-merging this, and will publish manually.

@divmain divmain deleted the feature/es-umd-builds branch February 13, 2018 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants