Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added content blocks list helper #66

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Conversation

iduuck
Copy link
Collaborator

@iduuck iduuck commented Feb 20, 2023

Motivation:
I used the q.contentBlock helper in one of my projects, and spend a lot of time, to debug, why it is telling me, that it is expecting an object, and received an array, until I saw, that contentBlock needs to be used with an array.

This helper helps mitigating this issue.

TODO:

  • Helper function
  • Test for helper function
  • Documentation in README

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea. I was talking to a colleague the other day that ran into the same problem!

Will you remove the pnpm lock file, and add a small blurb to the README and then tag me in a comment and we can get this merged/released ASAP!

@iduuck
Copy link
Collaborator Author

iduuck commented Feb 20, 2023

done @gksander

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gksander gksander merged commit ba8c5ba into FormidableLabs:main Feb 20, 2023
@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants