Calling setState without getInitialState throws when using PureRenderMixin

[ianobermiller]

Without getInitialState, this.state is null, which causes this line in shallowEqual to throw.

if (objB.hasOwnProperty(key) && !objA.hasOwnProperty(key)) {

Fix is to make shallowEqual bail if either argument is falsey (or not an object if we want to be very safe).

[sophiebits]

Is this with PureRenderMixin?

[ianobermiller]

Yes, I meant to link to the jsbin: http://jsbin.com/hogike/1/edit?html,js,console,output

I'm putting together a PR now.

[jimfb]

It is potentially worth noting that getInitialState is likely to become required for stateful components in the near future. See #3236 (comment)

It is already the case that any component calling setState() should ideally be specifying a getInitialState().

[joshbedo]

@JSFB I definitely think it makes sense to make getInitialState required for stateful components +1