This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Remove trailing commas + rules. #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 🚢 |
jaredbrookswhite
pushed a commit
to jaredbrookswhite/radium
that referenced
this pull request
Aug 22, 2018
…abs#940) Trailing commas add no "value" for correctness, and their absence is "always correct" for thing like older version of Node. Now that we actually lint all our JS files in Radium, it is easier to just remove trailing commas in lint than have different lint for transpiled src vs. "real node" root *.js files like webpack configs, etc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing commas add no "value" for correctness, and their absence is "always correct" for thing like older version of Node. Now that we actually lint all our JS files in Radium, it is easier to just remove trailing commas in lint than have different lint for transpiled
srcvs. "real node" root*.jsfiles like webpack configs, etc.Fixes #932
/cc @alexlande