Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Postcss in react-static@5 fails CSS building #857

Closed
2 tasks
ryan-roemer opened this issue Mar 6, 2020 · 1 comment
Closed
2 tasks

Docs: Postcss in react-static@5 fails CSS building #857

ryan-roemer opened this issue Mar 6, 2020 · 1 comment
Labels
🐛 Bug Issues or PRs that report or fix a bug ✓ Verified Org member or multiple community members can reproduce a given bug

Comments

@ryan-roemer
Copy link
Member

ryan-roemer commented Mar 6, 2020 •
edited
Loading

Probably will go away with #838 upgrade to react-static@7, but for how we're hitting this:

$ yarn prod:build
ERROR in ./node_modules/prismjs/themes/prism.css
Module build failed: ModuleBuildError: Module build failed: BrowserslistError: Unknown browser query `dead`
    at error (/Users/rye/scm/fmd/spectacle/docs/node_modules/browserslist/index.js:37:11)
    at /Users/rye/scm/fmd/spectacle/docs/node_modules/browserslist/index.js:222:9
    at Array.forEach (<anonymous>)
    at browserslist (/Users/rye/scm/fmd/spectacle/docs/node_modules/browserslist/index.js:196:13)
    at cleanBrowsersList (/Users/rye/scm/fmd/spectacle/docs/node_modules/caniuse-api/dist/utils.js:56:59)
    at setBrowserScope (/Users/rye/scm/fmd/spectacle/docs/node_modules/caniuse-api/dist/index.js:29:43)
    at Object.<anonymous> (/Users/rye/scm/fmd/spectacle/docs/node_modules/caniuse-api/dist/index.js:91:1)
    at Module._compile (internal/modules/cjs/loader.js:955:30)
    at Module._extensions..js (internal/modules/cjs/loader.js:991:10)
    at Object.require.extensions.<computed> [as .js] (/Users/rye/scm/fmd/spectacle/docs/node_modules/babel-register/lib/node.js:152:7)
    at /Users/rye/scm/fmd/spectacle/docs/node_modules/webpack/lib/NormalModule.js:195:19
    at /Users/rye/scm/fmd/spectacle/docs/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /Users/rye/scm/fmd/spectacle/docs/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at runSyncOrAsync (/Users/rye/scm/fmd/spectacle/docs/node_modules/loader-runner/lib/LoaderRunner.js:143:3)
    at iterateNormalLoaders (/Users/rye/scm/fmd/spectacle/docs/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
    at iterateNormalLoaders (/Users/rye/scm/fmd/spectacle/docs/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
    at /Users/rye/scm/fmd/spectacle/docs/node_modules/loader-runner/lib/LoaderRunner.js:236:3
    at context.callback (/Users/rye/scm/fmd/spectacle/docs/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /Users/rye/scm/fmd/spectacle/docs/node_modules/postcss-loader/lib/index.js:187:9
 @ ./src/app.js 33:0-35
 @ ./src/index.js

See, e.g.: browserslist/browserslist#266

Going to temporarily disable CSS minification.

Task

  • Fix build error
  • Reenable css minification.
@ryan-roemer ryan-roemer added 🐛 Bug Issues or PRs that report or fix a bug ✓ Verified Org member or multiple community members can reproduce a given bug rewrite labels Mar 6, 2020
@ryan-roemer
Copy link
Member Author

Should not block spectacle@6 release

@ryan-roemer ryan-roemer mentioned this issue Mar 6, 2020
Merged
1 task
ryan-roemer added a commit that referenced this issue Mar 6, 2020
@ryan-roemer
BUG: Prism production build failure + misc. (#858)
b41d735 
- Bandaid prism postcss minification bug by disabling CSS minification. For #857 as a temporary measure.
- Add missing `docs/dist-prod/open-source/spectacle` symlink needed for `yarn prod:serve`
- Catch `yarn.lock` up. This should fail yarn install in CI, so not sure if this is something just on my machine as I didn't change deps...
- Lint was super slow, so I updated lints so docs one is more honed (had duplicates) and root project one now only lints specific dirs (it was doing way too many after docs addition of things that were not real source) and does the root + docs so you only really need the root one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Issues or PRs that report or fix a bug ✓ Verified Org member or multiple community members can reproduce a given bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryan-roemer @kale-stew