Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Bug/fix dy calculation #245

Merged
merged 4 commits into from
May 12, 2017
Merged

Bug/fix dy calculation #245

merged 4 commits into from
May 12, 2017

Conversation

DerekMaffett
Copy link
Contributor

@DerekMaffett DerekMaffett commented May 10, 2017

It looks like we had a font-size variable getting factored into the global text element offset rather than just the individual tspan lines.

FormidableLabs/victory#577

@DerekMaffett DerekMaffett requested a review from boygirl May 10, 2017 20:17
@boygirl
Copy link
Contributor

boygirl commented May 10, 2017

This changes styling for labels:

Before:
screen shot 2017-05-10 at 2 44 54 pm

After:
screen shot 2017-05-10 at 2 44 32 pm

@DerekMaffett
Copy link
Contributor Author

I couldn't find a working old version of this - the fontSize multiplier was put in about a year ago and it seems like the labels would have been misplaced before that. FormidableLabs/victory#276

I think it was probably intended to only apply to the special adjustments though and not to the dy itself. I moved the multiplier into the getDy method so the labels are unchanged while custom dy values work.

@boygirl
Copy link
Contributor

boygirl commented May 12, 2017

@DerekMaffett much better! Approved!

@DerekMaffett DerekMaffett merged commit eae711e into master May 12, 2017
@DerekMaffett DerekMaffett deleted the bug/fix-dy-calculation branch May 12, 2017 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants