Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Glyph bbox was incorrect in the Firefox dev console #19925

Closed
2 tasks done
tchapeaux opened this issue Oct 2, 2023 · 20 comments
Closed
2 tasks done

Bug: Glyph bbox was incorrect in the Firefox dev console #19925

tchapeaux opened this issue Oct 2, 2023 · 20 comments
Assignees

Comments

@tchapeaux
Copy link

tchapeaux commented Oct 2, 2023

Bug description

When using FontAwesome v6 with Firefox (118), I'm seeing many warnings about FontAwesome glyphs in the console.

For example:

downloadable font: Glyph bbox was incorrect (glyph ids 5 9 10 12 13 15 16 33 49 59 60 61 72 76 81 83 84 85 88 91 92 97 101 102 103 104 106 107 109 118 120 121 122 124 134 135 136 137 139 141 143 145 146) (font-family: "Font Awesome 6 Pro" style:normal weight:300 stretch:100 src index:0) source: https://ka-p.fontawesome.com/releases/v6.4.2/webfonts/pro-fa-light-300-18.woff2

According to this ticket in Firefox's bug tracker, this is not an issue with Firefox, but an actual bug in FontAwesome font definition.

Reproducible test case

https://codepen.io/Thomas-Chapeaux/pen/gOZdpMV

Screenshots

image

Font Awesome version

v6.4.2

Serving

Kit

Implementation

CSS

Browser and Operating System

  • Firefox Developer Edition (119.0b3)
  • Firefox (v118)

Web bug report checklist

  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@tchapeaux tchapeaux added bug needs-triage This bug needs to be confirmed labels Oct 2, 2023
@ve3
Copy link

ve3 commented Oct 3, 2023

Confirm bug happens on Firefox (tested with 118.0.1) but not on Chrome (tested with 117.0.59.xxx).

@sensibleworld
Copy link
Member

Thanks, folks. We've heard this report from a few folks. ​It looks like the Firefox team introduced a new tolerance check in their recent build. There are some glyphs that extend slightly beyond the bbox area (this is related to how curves are sometimes drawn differently between OTFs, TTFs, WOFFs, SVGs, etc). The good news is that there should be no issue with the icons from a visual standpoint (the cropping is so minute, that it's imperceptible for the most part).

​We're going to work on a fix on our end, but there should be no issue with continuing to use the typeface... it'll continue to display as normal.

@TheJaredWilcurt
Copy link

TheJaredWilcurt commented Oct 4, 2023

@sensibleworld This is also occurring in v4.

Can we get a fix there too and a bump to 4.7.1 for the npm package? npm's stats show over 2 million downloads of 4.7.0 in the past 7 days.

@tagliala
Copy link
Member

tagliala commented Oct 5, 2023

v4 is in EOL and that npm package is not official. You can try to get in touch with the author

@Zahen
Copy link

Zahen commented Oct 5, 2023

Same warning with :

  • Firefox Dev v119.0b5 (64 bits)
  • @fortawesome/fontawesome-free v6.3.0
  • mdb-angular-ui-kit v4.10
  • Angular v15.2.4

@TheJaredWilcurt
Copy link

Unfortunately the GitHub repo that published the npm package does not have an issues page to report this.

Unless @juliankrispel sees this and is willing to modify the font files and do a new release, I'm guessing those contributing to the 2 million+ downloads a week will need to either live with the warning, or switch to something else that is maintained.

@epugh
Copy link

epugh commented Oct 16, 2023

I use https://github.com/FortAwesome/font-awesome-sass and am seeing the same issue.

@tagliala tagliala removed the needs-triage This bug needs to be confirmed label Oct 16, 2023
@baguaboy758
Copy link

Same with font awesome pro 6 (latest) and subsetter compiles

@hexkey
Copy link

hexkey commented Nov 2, 2023

Bump :)

@Lemmings19
Copy link

+1

@gustavocardoso
Copy link

Bump!!!

@melroy89
Copy link

This is a feature not a bug 🐛 .

@mlwilkerson
Copy link
Member

The fix has been completed and will appear in a forthcoming release of Font Awesome. The fix will be present in the official fonts for that forthcoming release, as well as fonts built when downloading or subsetting kits from fontawesome.com.

@hexkey
Copy link

hexkey commented Nov 19, 2023

Awesome, thank you.

@RolandMarchand
Copy link

Wonderful, greatly appreciated.

@akimd
Copy link

akimd commented Nov 23, 2023

Great news.

@ingodwetryst
Copy link

The fix has been completed and will appear in a forthcoming release of Font Awesome. The fix will be present in the official fonts for that forthcoming release, as well as fonts built when downloading or subsetting kits from fontawesome.com.

Has that happened yet? If not, do we have an ETA? Thanks!

@cadeyrn
Copy link

cadeyrn commented Jan 9, 2024

Has that happened yet? If not, do we have an ETA? Thanks!

Yes, it's fixed in Font Awesome 6.5.

@winternet-studio
Copy link

What about fixing this in version 5 which is an LTS that should still receive patch releases?

@joshmckibbin
Copy link

What about fixing this in version 5 which is an LTS that should still receive patch releases?

Not sure this qualifies as a "critical bug fix", at least not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests