Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Update FontAwesome to 6.5.1 #42721

Merged
merged 2 commits into from Jan 29, 2024
Merged

[5.1] Update FontAwesome to 6.5.1 #42721

merged 2 commits into from Jan 29, 2024

Conversation

C-Lodder
Copy link
Member

Summary of Changes

Update FontAwesome to 6.5.1

This also fixes a bug that was showing a warning in the Firefox dev console:

image

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Jan 28, 2024
@Fedik Fedik added the bug label Jan 28, 2024
@Fedik
Copy link
Member

Fedik commented Jan 28, 2024

I have tested this item ✅ successfully on 03752b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42721.

@brianteeman
Copy link
Contributor

From previous comments non-security dependency updates are done by the release lead as part of the beta release process

@Fedik
Copy link
Member

Fedik commented Jan 28, 2024

Can this be related to?

@brianteeman
Copy link
Contributor

Can this be related to?

anything is possible

@trananhmanh89
Copy link
Contributor

Can this be related to?

Does this pr affect to fontawesome of atum template?

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 03752b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42721.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42721.

1 similar comment
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42721.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 28, 2024
@wilsonge wilsonge enabled auto-merge (squash) January 28, 2024 23:42
@wilsonge wilsonge merged commit f184616 into joomla:5.1-dev Jan 29, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 29, 2024
@Quy Quy added this to the Joomla! 5.1.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants