Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add less and scss to main in bower [BREAKING CHANGE] #6227

Closed
wants to merge 1 commit into from

Conversation

stevemao
Copy link

Make wiredep or other bower tools work for less and scss version.

@cvrebert
Copy link

Also, per the updated bower.json spec for main (bower/spec@0b34d2b):

  • CSS should be excluded if the Less/Sass it's generated from is included
  • Globs are invalid
  • Font files shouldn't be included (tools are supposed to detect them based on extension/file-type or by virtue of them being referenced in the Less/Sass/CSS)

@tagliala tagliala added this to the 4.3.1 milestone May 28, 2015
@tagliala tagliala self-assigned this May 28, 2015
@tagliala
Copy link
Member

so it should be

"main": [
  "less/font-awesome.less",
  "scss/font-awesome.scss"
],

?

@cvrebert
Copy link

Correct.

@tagliala
Copy link
Member

@cvrebert thanks

@stevemao could you please update this PR and force push?

@stevemao
Copy link
Author

Done. But what if people are not use scss or less but just css?

@stevemao stevemao force-pushed the patch-1 branch 4 times, most recently from 3d86d43 to 7343eba Compare May 28, 2015 23:14
CSS should be excluded if the Less/Sass it's generated from is included
Globs are invalid
Font files shouldn't be included

Ref: bower/spec#43
@tagliala
Copy link
Member

@stevemao I've just read this blogpost

http://blog.getbootstrap.com/2015/06/15/bootstrap-3-3-5-released/#wiredep-and-bower

does it help you?

@stevemao
Copy link
Author

Yes, that's exactly what concerns me.
bower/spec#47 should resolve this

@tagliala
Copy link
Member

Done via 1188452

thanks!

closing here

@tagliala tagliala changed the title Add less and scss to main in bower Add less and scss to main in bower [BREAKING CHANGE] Sep 21, 2015
@tagliala
Copy link
Member

Sorry for this breaking change but please use overrides

  "overrides": {
    "font-awesome": {
      "main": [
        "./css/font-awesome.css",
        "./fonts/*"
      ]
    }
  }

Refers to twbs/bootstrap#16663

🔒

@FortAwesome FortAwesome locked and limited conversation to collaborators Sep 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants