Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default sampling rate (#32) #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Feb 26, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Changed default sampling rate from 44.1 kHz to 48 kHz, so there's no need to write any conditions to check for Opus.
  • Tested on real mobile and recording in 48 kHz works correctly for each of three file types.
  • I've also cross-tested with the released version and Opus now sounds as it should.
  • We can let users change to 44.1 kHz with implementing Re-sampling between different kHz / Choosing the sample rate at recording #33 in the future.

Fixes the following issue(s)

Acknowledgement

@David-Else
Copy link

Any idea when this and #36 will be merged?

@Aga-C
Copy link
Member Author

Aga-C commented Apr 15, 2024

It should be merged before the release of the next version, but I can't tell you when exactly it will happen. Please wait patiently.

@SilverPuppy
Copy link

SilverPuppy commented Oct 1, 2024

This will work for now. I second the eagerness to see it released.

If anyone wondered, this behavior is because Opus does not support 44,100 at all, so it encodes the samples anyway but marks it as the nearest thing supported, 48,000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OggOpus records in 44.1 kHz but marks file as 48 kH
3 participants