-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagrams Colors Accessibility Problems #15
Comments
Update diagrams' README with info about the new color palette that will be adopted for diagrams' BG colors. The new scheme was designed to solve the color contrast accessibility issues of the original palette (fixes #15) and reduces the number of palette entries by eliminating redundant similar colors. * `diagrams-palette.cifc` -- ColorImpact 4 palette project. * `diagrams-palette.html` -- Palette color spec document. * `diagrams-palette.png` -- Palette swatches.
@SicroAtGit, how do you like the new color scheme? I personally like it, even though the pinkish color is a bit louder than others, but the readability is now greatly improved (before, I could hardly read some of the diagrams with dark BG colors, especially the purple). Anyhow, the colors' contrast accessibility values were tested one by one, and they passed all criteria. Since the whole scheme was generated via color harmonies (using perceptual algorithms, not mere digital color manipulations), the palette is well balanced. Also, I like the newly adopted fonts better.... |
I like the new colors too. Much better readable and looks fresher. Very good work! |
Diagram
|
Yes, I've noticed that too, I was kind of postponing its fix. Neither the grey from the original palette nor the one from the newer one seem to work well there. I've tried lighter and darker greys, but non of them really work, unless they are so near to black that they don't look grey at all. White didn't work either (it's easier to read but fails WebAIM). The original diagram is poorly readable too.
Hadn't checked that, but I had no doubt it would fail since it looks awful to read.
I haven't tried that, I'll give it a go. Probably using italics might be better, because I believe the original intention was to make it sort of "fade away", to indicate it's "before" state. Bold would give it stronger emphasis, so it might be misleading in this context. On the other hand, in the original diagram italics are used to indicate abstract concepts, like some sort of comments to the picture. I wonder why they didn't also paint the box background in lighter colour (as they did in other diagrams). I wasn't sure how to handle this problem. In general, I get the feeling that there's a consistent method to how the colours and text styles were chosen in the original diagrams. So I was surprised they didn't use the faded colours for the whole Probably, after reading the whole book again, for the final proofreading, I'll get a better picture of how the original authors intended to use colours, text styles, etc. to indicate different aspects of the various steps of Git/SVN, which should then enable me to make a better choice in this respect. I've create a dedicated Issue (#17) for this diagram needing to be fixed. I think this was the only one showing this problem, but I'm not sure (was working under pressure, due to limited free time). |
Oh, yes, that's right, then I see this as better as well:
Yes, only this diagram. |
The original color diagrams use a common palette which contains various shades of same basic colors.
Some of these colors, in their darker shades, fail to pass some of the Contrast and Color Accessibility test. For example,
git-objects.svg
(Fig.4 of the book):Some of these background colors don't fair too well on the WebAIM on-line contrast checker when tested against a black foreground text:
#8086AC
#699768
#C5919B
(click on color values to view their WebAIM on-line tests)
WCAG AA/AAA Results for Normal Text
Only one of the above BG/FG colors meets the triple AAA standard of the WCAG (Web Content Accessibility Guidelines) when tested for normal text sizes:
#8086AC
#699768
#C5919B
WCAG AA/AAA Results for Large Text and UI Components
All colors meet the WCAG AA and AAA for large text and for Graphical Objects and User Interface Components:
#8086AC
#699768
#C5919B
Overall, I find these shades are too dark and hard to read, especially in diagrams containing small text, or which are packed with lots of text.
We might also just keep using the lighter shades, and replace the darker ones.
But I think that we could come up with a better color palette altogether (less dull, possibly with light pastel colors which are slightly more vibrant).
The text was updated successfully, but these errors were encountered: