Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce ResolvedAccessor #1900

Merged
merged 1 commit into from
Nov 8, 2022
Merged

introduce ResolvedAccessor #1900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../java/com/apple/foundationdb/record/query/plan/cascades/AggregateIndexMatchCandidate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ private static void addCoveringField(@Nonnull IndexKeyValueToPartialRecord.Build
@Nonnull AvailableFields.FieldData fieldData) {
// TODO field names are for debugging purposes only, we should probably use field ordinals here instead.
final var simplifiedFieldValue = (FieldValue)fieldValue.simplify(AliasMap.emptyMap(), ImmutableSet.of());
for (final var maybeFieldName : simplifiedFieldValue.getFieldPrefix().getFieldNamesMaybe()) {
for (final var maybeFieldName : simplifiedFieldValue.getFieldPrefix().getOptionalFieldNames()) {
Verify.verify(maybeFieldName.isPresent());
builder = builder.getFieldBuilder(maybeFieldName.get());
}
Expand Down
2 changes: 1 addition & 1 deletion .../java/com/apple/foundationdb/record/query/plan/cascades/ValueIndexScanMatchCandidate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ private static boolean addCoveringField(@Nonnull IndexKeyValueToPartialRecord.Bu
@Nonnull FieldValue fieldValue,
@Nonnull AvailableFields.FieldData fieldData) {
// TODO field names are for debugging purposes only, we should probably use field ordinals here instead.
for (final var maybeFieldName : fieldValue.getFieldPrefix().getFieldNamesMaybe()) {
for (final var maybeFieldName : fieldValue.getFieldPrefix().getOptionalFieldNames()) {
if (maybeFieldName.isEmpty()) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion ...va/com/apple/foundationdb/record/query/plan/cascades/WindowedIndexScanMatchCandidate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ private static boolean addCoveringField(@Nonnull IndexKeyValueToPartialRecord.Bu
@Nonnull FieldValue fieldValue,
@Nonnull AvailableFields.FieldData fieldData) {
// TODO field names are for debugging purposes only, we should probably use field ordinals here instead.
for (final var maybeFieldName : fieldValue.getFieldPrefix().getFieldNamesMaybe()) {
for (final var maybeFieldName : fieldValue.getFieldPrefix().getOptionalFieldNames()) {
if (maybeFieldName.isEmpty()) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion ...a/com/apple/foundationdb/record/query/plan/cascades/matching/structure/ValueMatchers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public static <V extends Value> BindingMatcher<FieldValue> fieldValueWithFieldPa
downstreamValue);
final TypedMatcherWithExtractAndDownstream<FieldValue> downstreamFieldPathOrdinalsMatcher =
typedWithDownstream(FieldValue.class,
Extractor.of(f -> f.getFieldPathOrdinals().asList(), name -> "fieldPathOrdinals(" + name + ")"),
Extractor.of(f -> f.getFieldOrdinals().asList(), name -> "fieldPathOrdinals(" + name + ")"),
downstreamFieldPathOrdinals);
final TypedMatcherWithExtractAndDownstream<FieldValue> downstreamFieldPathTypesMatcher =
typedWithDownstream(FieldValue.class,
Expand Down
Loading