Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for updates banner is annoying when using a third-party distribution that lags behind releases #1229

Closed
KristerV opened this issue Nov 12, 2018 · 12 comments
Labels
linux migrated Migrated to Discourse

Comments

@KristerV
Copy link

Are there any related issues? no
What operating system are you using? Arch Linux
Feature Request?

I would like to either disable checking for updates or just hide the notification.

image

I'm on Arch Linux and the AUR repo is kept up to date pretty well. I am not going to download the app manually and I don't want to update my computer every time MailSpring says so. I have a once-a-month update schedule.

This notification hides needed info and it's color takes my attention away - super annoying and not useful.

@bengotow
Copy link
Collaborator

Hey! Sorry for the delay—please use the Snapcraft release if you can! It autoupdates and doesn't display the notifications. It's great someone is maintaining an AUR repo but it's not us. I'll see if maybe we can take it over or publish an official AUR package in the future!

@bengotow bengotow added the linux label Nov 22, 2018
@bengotow bengotow changed the title Disable 'check for updates' Check for updates banner is annoying when using a third-party distribution that lags behind releases Nov 22, 2018
@itszaen
Copy link

itszaen commented Feb 27, 2019

Having the same annoyance, I would really just like an option in the settings menu to disable the banner. Or an "x" button to hide the banner for a period of time, although not ideal.

@nelai1
Copy link

nelai1 commented Mar 15, 2019

using the snap on ubuntu, still seeing this annoying banner

@jnylen
Copy link

jnylen commented Mar 18, 2019

@bengotow Hi,
I'm the one that created the aur repo in the beginning and are collabing on it again.

Is there a safe way to disable the update notification? Such as setting the updateAvailable = false in the update-notification file? Just making sure.

Do mind we use the .deb file in the AUR repo.

@marxistvegan
Copy link

Same issue in the Solus Project (https://getsol.us) the notification is very annoying and will get updated on a weekly basis so being able to turn off that notification would be greatly appreciated.

@friday
Copy link

friday commented Mar 20, 2019

I found a hacky way to disable it, which requires asar:

From the path app.asar is in:

asar extract app.asar app
sed -i 's/updater.getState()/0/g' app/internal_packages/notifications/lib/items/update-notification.js
asar pack app app.asar
rm -rf app

I'm not sure it's safe, but it worked for me. The result will be larger than the original app.asar since the original build step excludes some patterns. If someone is ambitious enough, it should be possible to ignore these form the cli too, or possibly rebuild only this with gulp. 😕

...or better yet, officially support disabling the banner so we don't have to.

Addition: Hijacking the update url seems to work too:

echo -e '\n127.0.0.1 updates.getmailspring.com' | sudo tee -a /etc/hosts

@Stefan538871
Copy link

@bengotow Hi,
I know this issue started 2018 and the last comment was march 2019.
I just want to mention that I use fedora31 and apparently the rpmfusion repo is behind aswell.

Since you already mentioned snap, would it be possible to distribute this app as flatpak too?
Or as someone already mentioned an option in the settings menu to disable auto updates.
Aside from that, great email client :)

@KristerV
Copy link
Author

@Stefan538871 that is called thread hijacking. Also this thread is stale, so closing.

@friday
Copy link

friday commented Apr 11, 2020

Why @KristerV? Others want to keep track of the development too and invested time in finding this issue, subscribing. commenting etc.

@KristerV
Copy link
Author

KristerV commented Apr 11, 2020

oh, well kudos for replying fast, sure I'll reopen it then. Thought since the last comment was over a year ago.. Just for info: I'm unsubscribing since am happy with Fastmail's web interface in Franz.

@KristerV KristerV reopened this Apr 11, 2020
@CodeMouse92 CodeMouse92 added the audit Auditing issue label Jan 12, 2021
@foundry376-bot
Copy link

This issue has been mentioned on Mailspring Community. There might be relevant details there:

https://community.getmailspring.com/t/check-for-updates-banner-is-annoying-when-using-a-third-party-distribution-that-lags-behind-releases/542/1

@CodeMouse92
Copy link
Contributor

We are in the process of migrating issues to Discourse, which can better facilitate discussion and discovery, and so GitHub Issues can focus on issues that are confirmed and slated for resolution in the near term. Learn more about the changes here.

As part of this, we've migrated this issue to Discourse:

https://community.getmailspring.com/t/check-for-updates-banner-is-annoying-when-using-a-third-party-distribution-that-lags-behind-releases/542

Please consider joining that community and continuing the discussion there! Votes on the feature suggestion on Discourse will increase the likelihood we implement this.

@KristerV @jnylen @marxistvegan @friday: if you join and reply to the issue, the moderators can make an effort to reassign your posts to you, so you get the credit for them.

We're closing and locking the issue here as part of this migration. Rest assured, this doesn't mean the issue is being discarded or ignored.

We hope to see you on Discourse soon!

-The Mailspring Team

@Foundry376 Foundry376 locked and limited conversation to collaborators Feb 10, 2021
@CodeMouse92 CodeMouse92 added migrated Migrated to Discourse and removed audit Auditing issue labels Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linux migrated Migrated to Discourse
Projects
None yet
Development

No branches or pull requests

10 participants