Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultilayerQG module (and possibly others) has trouble when trying to use Float32 #21

Closed
navidcy opened this issue Jun 30, 2019 · 4 comments
Closed

MultilayerQG module (and possibly others) has trouble when trying to use Float32 #21

navidcy opened this issue Jun 30, 2019 · 4 comments
Assignees
@glwagner
Labels
🐞 bug Something isn't working

Comments

@navidcy
Copy link
Member

navidcy commented Jun 30, 2019

I believe we didn't write the module general enough; we should look into that.
@navidcy navidcy added the 🐞 bug Something isn't working label Jun 30, 2019
@navidcy
Copy link
Member Author

navidcy commented Jun 30, 2019

Part of the problem is related to
FourierFlows/FourierFlows.jl#108

Another part of the problem is that MultilayerQG assumes Float64 arrays in certain points (this is easy to fix... I think).

@navidcy
Copy link
Member Author

navidcy commented Jul 2, 2019

A not-so-elegant attempt to resolve this is 046c607#r34146938

@navidcy
Copy link
Member Author

navidcy commented Sep 1, 2019

#28 attempts to resolve this issue (in MultiLayerQG module)

@navidcy
Copy link
Member Author

navidcy commented Sep 5, 2019

#30 attempts to resolve issues in all modules.

@navidcy navidcy closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glwagner glwagner

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@navidcy @glwagner