Fix Problem type in MultilayerQG #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id confusion with gravitational constant)
…Flows/GeophysicalFlows.jl into FixTypedProbMultilayerQG
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 97.84% 97.85% +<.01%
==========================================
Files 6 6
Lines 511 513 +2
==========================================
+ Hits 500 502 +2
Misses 11 11
Continue to review full report at Codecov.
|
glwagner
approved these changes
Sep 3, 2019
| mu = 5e-2 # bottom drag | ||
| beta = 5 # the y-gradient of planetary PV | ||
| Lx = 2π # domain size | ||
| μ = 5e-2 # bottom drag |
| calcS!(S, Fp, Fm, grid) | ||
|
|
||
| invS = Array{Float64}(undef, (nkr, nl, nlayers, nlayers)) | ||
| invS = Array{T}(undef, (nkr, nl, nlayers, nlayers)) |
| Vars(q, psi, u, v, qh, psih, uh, vh) | ||
| end | ||
|
|
||
| """ | ||
| ForcedVars(g) | ||
|
|
||
| Returns the vars for forced multi-layer QG problem with grid g. | ||
| Returns the vars for forced multi-layer QG problem with grid gr. |
There was a problem hiding this comment.
Use "gr" (with backticks) if you want it to render as code in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some type instability in the MultilayerQG Problem constructor.
@glwagner: if you are happy with this merge and then create a new branch to implement
nlayersas a type-parameter ofParamsandVars.