Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes type instabilities in various modules #30

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Fixes type instabilities in various modules #30

merged 4 commits into from
Sep 10, 2019

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Sep 5, 2019

No description provided.

@navidcy navidcy mentioned this pull request Sep 5, 2019
Closed
@coveralls
Copy link

coveralls commented Sep 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 267

  • 20 of 20 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 98.441%
Totals Coverage Status
Change from base Build 251: 0.6%
Covered Lines: 505
Relevant Lines: 513
💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #30 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   97.85%   98.05%   +0.19%     
==========================================
  Files           6        6              
  Lines         513      513              
==========================================
+ Hits          502      503       +1     
+ Misses         11       10       -1
Impacted Files Coverage Δ
src/twodturb.jl 97.36% <100%> (+1.31%) ⬆️
src/multilayerqg.jl 95.42% <100%> (ø) ⬆️
src/barotropicqg.jl 100% <100%> (ø) ⬆️
src/barotropicqgql.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dcf03c...51d6f73. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #30 into master will increase coverage by 0.58%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   97.85%   98.44%   +0.58%     
==========================================
  Files           6        6              
  Lines         513      513              
==========================================
+ Hits          502      505       +3     
+ Misses         11        8       -3
Impacted Files Coverage Δ
src/twodturb.jl 100% <100%> (+3.94%) ⬆️
src/multilayerqg.jl 95.42% <100%> (ø) ⬆️
src/barotropicqg.jl 100% <100%> (ø) ⬆️
src/barotropicqgql.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dcf03c...32b28a0. Read the comment docs.

@navidcy navidcy added the 🐞 bug Something isn't working label Sep 5, 2019
glwagner
glwagner approved these changes Sep 10, 2019
View reviewed changes
src/multilayerqg.jl Outdated
@@ -59,7 +59,7 @@ function Problem(;
T = Float64)

grid = TwoDGrid(nx, Lx, ny, Ly; T=T)
params = Params(nlayers, T(g), T(f0), T(beta), Array{T}(rho), Array{T}(H), Array{T}(U), Array{T}(eta), T(μ), T(ν), nν, grid, calcFq=calcFq)
params = Params(nlayers, g, f0,beta, Array{T}(rho), Array{T}(H), Array{T}(U), Array{T}(eta), μ, ν, nν, grid, calcFq=calcFq)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn! you caught me!

@glwagner
Copy link
Member

Looks good! Merge when ready.

Comment: we seem to have strayed from the julia style recommendation for function arguments:

https://docs.julialang.org/en/v1/manual/style-guide/index.html#Write-functions-with-argument-ordering-similar-to-Julia-Base-1

where it is suggested that types, when used as arguments to functions should come first (think zeros(Int, 3, 3), etc).

Not a big deal, but maybe something to address in the future for the TwoDGrid constructor.

@navidcy navidcy merged commit 7ab52d1 into master Sep 10, 2019
@navidcy navidcy deleted the FixTypeInstabilities branch September 10, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navidcy @coveralls @glwagner