Changed Webhook Auth Logic

FoxSellApp · Jan 26, 2022 · 47e3a46 · 47e3a46
1 parent ab2daac
commit 47e3a46
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/smoothcode_auth/__init__.py b/smoothcode_auth/__init__.py
@@ -4,4 +4,4 @@
 
 from .auth import SmoothCodeAuth
 
-__version__ = '0.0.2'
+__version__ = '0.0.3'
diff --git a/smoothcode_auth/auth.py b/smoothcode_auth/auth.py
@@ -12,5 +12,5 @@ def is_dashboard_request(self, shop: str):
         return generate_hmac(self.client_secret, shop) == self.hmac
 
     def is_webhook_request(self, webhook_data: dict):
-        stringfied_webhook_data = json.dumps(webhook_data, separators=(',', ':'))
-        return generate_hmac(self.client_secret, stringfied_webhook_data) == self.hmac
+        webhook_id = webhook_data.get('id')
+        return generate_hmac(self.client_secret, str(webhook_id)) == self.hmac
diff --git a/tests/test_auth.py b/tests/test_auth.py
@@ -14,10 +14,10 @@ def test_is_dashboard_request_with_incorrect_data(self):
 
     def test_is_webhook_request_with_correct_data(self):
         client_secret = 'client_secret'
-        request_hmac = '656718377faf656ccc037d8607ebfe3434197981aa1362db81210252ce92cd5c'
-        assert SmoothCodeAuth(request_hmac, client_secret).is_webhook_request({'request': 'webhook'})
+        request_hmac = '3999c5c10e23bee670e28ad67f446ac5e7b9c47ca1ee39c4bdf0c7bf056f8d71'
+        assert SmoothCodeAuth(request_hmac, client_secret).is_webhook_request({'id': 1235643534})
 
     def test_is_webhook_request_with_incorrect_data(self):
         client_secret = 'client_secret'
         request_hmac = 'request_hmac'
-        assert not SmoothCodeAuth(request_hmac, client_secret).is_webhook_request({'request': 'webhook'})
+        assert not SmoothCodeAuth(request_hmac, client_secret).is_webhook_request({'id': 'webhook'})